-
Notifications
You must be signed in to change notification settings - Fork 15
chore: add zod2md-nx-plugin #1162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
View your CI Pipeline Execution ↗ for commit d1eb4f8
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 543447a with previous commit 270b474. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 3 groups improved, 👎 1 group regressed, 👍 6 audits improved, 👎 3 audits regressed, 14 audits changed without impacting score🗃️ Groups
30 other groups are unchanged. 🛡️ Audits
656 other audits are unchanged. |
Code PushUp😟 Code PushUp report has regressed – compared current commit 543447a with previous commit 270b474. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🔴 45 | 🔴 45 |
5 other categories are unchanged.
👎 1 group regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDocs coverage | Documentation coverage | 🔴 45 | 🔴 45 |
14 other groups are unchanged.
🛡️ Audits
All of 444 audits are unchanged.
13 other projects are unchanged.
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
|
After switching to After the update errors popped up that i could not fully relate to the changes: @matejchalk could you check this changes pls. |
# Conflicts: # package-lock.json # package.json
# Conflicts: # packages/plugin-eslint/src/lib/eslint-plugin.int.test.ts
|
I was able to resolve the same issue in NX v22 without changed in tests. (related: #1162 (comment)) |
| } | ||
|
|
||
| module.exports = annotateTypeDefinitions; | ||
| export { annotateTypeDefinitions as default }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you're using the default export anymore.
| export { annotateTypeDefinitions as default }; |
The only reference to this module is in index.ts, which uses a named import.
cli/tools/zod2md-jsdocs/src/index.ts
Lines 1 to 8 in 2ac556a
| import { annotateTypeDefinitions } from './lib/transformers.js'; | |
| export { | |
| annotateTypeDefinitions, | |
| generateJSDocComment, | |
| } from './lib/transformers.js'; | |
| export default annotateTypeDefinitions; |
| "generate-docs", | ||
| { "projects": "zod2md-jsdocs", "target": "build" } | ||
| { "projects": "zod2md-jsdocs", "target": "build" }, | ||
| { "projects": "zod2md-jsdocs", "target": "ts-patch" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to add these dependencies manually? Couldn't the plugin infer them based on the existence of zod2md.config.ts? It's looking like a leaky abstraction at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I will automate this part in: #1188 (followup of this one).
What I already did is considering the cleanest solution..
ATM I believe I will:
-
implement a sync generator to
- do the ts config file update of the TS transformer based on the presence of
zod2md.config.ts - do the build target implementation either in a plugin, or move the docs build step into sync generator
As my opinion could change when starting to clean up build config i thought I keep that part out in this PR.
- do the ts config file update of the TS transformer based on the presence of
Followup of #1163
Precondition of #1188
This PR includes:
zod2md-jsdocszod2md.config.tsA potential followup PR could implement a nx plugin for our
buildtarget and adddependsOnsettings automatically. This is also noted in a clean up issue.Note
This is tooling code and it is not planned to get released
Related:
#1168